Fix fileinfo support - #1179
Merged
Merged
Conversation
bgrgicak
added
[Type] Bug
bgrgicak
marked this pull request as ready for review
April 2, 2024 08:26
Collaborator
|
@bgrgicak Thank you, I forgot a lot of things in my previous Pull Request. |
adamziel
approved these changes
Apr 2, 2024
adamziel
left a comment
adamziel
left a comment
Collaborator
There was a problem hiding this comment.
Approving, but merging will require rebuilding WASM since I merged your other WASM PR. Thank you!
bgrgicak
force-pushed
the
fix/kitchen-sink-fileinfo-support
branch
from
April 3, 2024 05:35
13cdd83 to
30b4302
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1127
What is this PR doing?
It enables
fileinfosupport in kitchen-sink and Node and adds tests for it.What problem is it solving?
Allows users to use
fileinfo.How is the problem addressed?
By fixing a bug in the build script that prevented
fileinfofrom being enabled.Testing Instructions