Update the networking disabled error messages in wp-admin for plugins and themes - #936
Merged
adamziel merged 7 commits intoJan 23, 2024
Conversation
adamziel
reviewed
Jan 12, 2024
Collaborator
|
Thank you @ironnysh! I left a small request but this looks pretty good otherwise. To make the CI checks pass you'll also need to adjust the check in this E2E test: |
Collaborator
Author
adamziel
reviewed
Jan 15, 2024
adamziel
reviewed
Jan 15, 2024
Collaborator
Author
|
Hi @adamziel, here's hoping this time it's okay :-) Also found a hacky solution for this:
and this:
|
Collaborator
Author
|
Yay! Thanks for your patience and support 🤓 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
Displays a revised error message when trying to install a new plugin or theme while networking is disabled (the default state). See #927.
What problem is it solving?
The current version of the error message doesn't include an explanation on how to enable networking.
How is the problem addressed?
Suggests two possible ways to solve the problem, including examples and links to the documentation.
Testing Instructions
Launch a Playground instance, navigate to Add Themes or Add Plugins, and see the error message.