Skip to content

Update the networking disabled error messages in wp-admin for plugins and themes - #936

Merged
adamziel merged 7 commits into
WordPress:trunkfrom
ironnysh:update-networking-error-message
Jan 23, 2024
Merged

Update the networking disabled error messages in wp-admin for plugins and themes#936
adamziel merged 7 commits into
WordPress:trunkfrom
ironnysh:update-networking-error-message

Conversation

@ironnysh

Copy link
Copy Markdown
Collaborator

What is this PR doing?

Displays a revised error message when trying to install a new plugin or theme while networking is disabled (the default state). See #927.

What problem is it solving?

The current version of the error message doesn't include an explanation on how to enable networking.

How is the problem addressed?

Suggests two possible ways to solve the problem, including examples and links to the documentation.

Testing Instructions

Launch a Playground instance, navigate to Add Themes or Add Plugins, and see the error message.

@adamziel

Copy link
Copy Markdown
Collaborator

Thank you @ironnysh! I left a small request but this looks pretty good otherwise. To make the CI checks pass you'll also need to adjust the check in this E2E test:

it('should disable networking when requested', () => {
cy.visit('/?url=/wp-admin/plugin-install.php');
cy.wordPressDocument()
.find('.notice.error')
.should('contain', 'Enable networking support in Playground');
});

mk520888

This comment was marked as spam.

mk520888

This comment was marked as spam.

@ironnysh

Copy link
Copy Markdown
Collaborator Author

Hi @adamziel, thanks for your help! Let me know if anything is missing :-)

Thank you @ironnysh! I left a small request but this looks pretty good otherwise. To make the CI checks pass you'll also need to adjust the check in this E2E test:

Comment thread packages/playground/website/cypress/e2e/app.cy.ts
@ironnysh

Copy link
Copy Markdown
Collaborator Author

Hi @adamziel, here's hoping this time it's okay :-)

Also found a hacky solution for this:

Hmm, the button is part of core. Is there a way to hide it?

and this:

The error message appears twice on the Featured plugins tab.

@ironnysh
ironnysh requested a review from adamziel January 21, 2024 14:37

@adamziel adamziel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you @ironnysh! I think it's good to merge. I'll give it one more look tomorrow and then merge.

@adamziel
adamziel merged commit eb1a0a4 into WordPress:trunk Jan 23, 2024
@ironnysh

Copy link
Copy Markdown
Collaborator Author

Yay! Thanks for your patience and support 🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants