Skip to content

Commit 8e10976

Browse files
committed
Fix documentation and improve readability of unit test with rtpDataWithHeaderExtension example
1 parent 2c3c1a9 commit 8e10976

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

‎libraries/exoplayer_rtsp/src/test/java/androidx/media3/exoplayer/rtsp/RtpPacketTest.java‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,9 @@ public final class RtpPacketTest {
7171
/*
7272
10.. .... = Version: RFC 1889 Version (2)
7373
..0. .... = Padding: False
74-
...0 .... = Extension: True
74+
...1 .... = Extension: True
7575
.... 0000 = Contributing source identifiers count: 0
76-
1... .... = Marker: False
76+
0... .... = Marker: False
7777
Payload type: DynamicRTP-Type-96 (96)
7878
Sequence number: 61514
7979
Timestamp: 2000000000
@@ -127,12 +127,13 @@ public void parseRtpPacketWithLargeTimestamp() {
127127
}
128128

129129
@Test
130-
public void parseRtpPacketWithHeaderExtension() {
130+
public void parseRtpPacketWithHeaderExtension_createsRtpPacketWithoutHeaderExtension() {
131131
RtpPacket packet =
132132
checkNotNull(RtpPacket.parse(rtpDataWithHeaderExtension, rtpDataWithHeaderExtension.length));
133133

134134
assertThat(packet.version).isEqualTo(RtpPacket.RTP_VERSION);
135135
assertThat(packet.padding).isFalse();
136+
//created RtpPacket object will parse but not save the extension data
136137
assertThat(packet.extension).isFalse();
137138
assertThat(packet.csrcCount).isEqualTo(0);
138139
assertThat(packet.csrc).hasLength(0);

0 commit comments

Comments
 (0)