Skip to content

Commit 2fdbfe7

Browse files
committed
Fix link styling via SCSS instead of inline style
Move link underline styling from inline style to the existing .content_links .copyright div rule in content-perma.scss. Use color: inherit so the link matches surrounding text on both dark and white backgrounds. Signed-off-by: Tim Ren <137012659+xr843@users.noreply.github.com>
1 parent 8a37f13 commit 2fdbfe7

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

‎_includes/content_filelinks.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<div class="a-link">{% if is_archive_borrow %}<details class="copyright details-reset"><summary>{% endif %}<a class="btn" {% if include.newtab %}target="_blank"{% endif %} {% include content_link_data_attributes.html content=include.content linktype="Main External URL" linkfmt=linkfmt %} href="{{ include.content.external_url }}"{% for nrh in site.data.content.noreferrerhosts %}{% if include.content.external_url contains nrh %} rel="noreferrer"{% break %}{% endif %}{% endfor %}>{{ linkbody }}</a>{% if is_archive_borrow %}
1010
<i class="far fa-question-circle"></i>
1111
</summary><div>
12-
Reading this book on Archive.org may require a free account. <a href="https://help.archive.org/help/borrowing-from-the-lending-library/" style="text-decoration: underline">Learn more</a>
12+
Reading this book on Archive.org may require a free account. <a href="https://help.archive.org/help/borrowing-from-the-lending-library/">Learn more</a>
1313
</div></details>{% endif %}</div>
1414
{% endif %}
1515
{%- if include.content.drive_links.size > 0 -%}

‎assets/css/content-perma.scss‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,10 @@ div.content_links {
147147
padding: 5px;
148148
border-radius: 3px;
149149
font-size: 96%;
150+
a {
151+
text-decoration: underline;
152+
color: inherit;
153+
}
150154
}
151155
}
152156

@@ -162,6 +166,4 @@ div.similar_content_footer {
162166
padding-bottom: 8px;
163167
}
164168
}
165-
}
166-
167-
169+
}

0 commit comments

Comments
 (0)