This repository was archived by the owner on Aug 3, 2023. It is now read-only.
Revert "Don't look for background updates unless Wrangler finished successfully" #2165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ccessfully" This reverts commit 45f5ab2 to avoid #2161. It's unclear to me why that would have introduced a regression, but this whole issue is actual Undefined Behavior according to the C standard, so it's basically impossible to predict the behavior of the program from the source code. I unfortunately wasn't able to reproduce the regression locally so I'm not sure whether this helps or not.
threepointone
approved these changes
Dec 22, 2021
delete-merged-branch
bot
deleted the
jnelson/revert-background-update
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 45f5ab2 to avoid #2161.
It's unclear to me why that would have introduced a regression,
but this whole issue is actual Undefined Behavior according to the C
standard, so it's basically impossible to predict the behavior of the program from the source code. I unfortunately wasn't able to reproduce the regression locally so I'm not sure whether this helps or not.
cc @Electroid @threepointone