Skip to content

fix: validate checksum of cached artifacts - #212

Merged
MarshallOfSound merged 1 commit into
mainfrom
validate-cache-checksum
Sep 5, 2023
Merged

fix: validate checksum of cached artifacts#212
MarshallOfSound merged 1 commit into
mainfrom
validate-cache-checksum

Conversation

@MarshallOfSound

Copy link
Copy Markdown
Member

Fixes #210

@ckerr ckerr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not up-to-speed with all the differences between pre-1.3.2 and post-1.3.4, but the code here looks reasonable

@malept malept changed the title fix: validate checksum of cached artifacts too Aug 9, 2022
@MarshallOfSound
MarshallOfSound requested a review from a team as a code owner September 5, 2023 07:26
@MarshallOfSound
MarshallOfSound merged commit 32211d4 into main Sep 5, 2023
@MarshallOfSound
MarshallOfSound deleted the validate-cache-checksum branch September 5, 2023 07:35
@continuous-auth

Copy link
Copy Markdown

🎉 This PR is included in version 2.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kanru

kanru commented Sep 9, 2023

Copy link
Copy Markdown

The new behavior seems to be always trying to download the checksum file even if all other files are cached.
I'm unable to build electron apps in a sandboxed builder (without network) due to this.
Could you let me know if I need to cache everything where should I put the SHASUMS256.txt file?

@MarshallOfSound

Copy link
Copy Markdown
Member Author

The new behavior seems to be always trying to download the checksum file even if all other files are cached.

This is the new correct/expected behavior.

Could you let me know if I need to cache everything where should I put the SHASUMS256.txt file?

Right next to the other files you were pre-filling the cache with

Worth noting that if you want to do this truly offline without prefilling the SHASUM file you could also provide a checksums object directly to @electron/get. This is for instance what the core electron npm package does --> https://github.com/electron/electron/blob/main/npm/install.js#L45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 participants