feat: Allow @electron/windows-sign to take over Squirrel codesigning - #501
Merged
Conversation
Contributor
|
Seems reasonable to me, it is important that Squirrel invoke signtool.exe (i.e. rather than trying to run Squirrel without signing then signing the EXE file after-the-fact) or else certain files will end up not signed correctly like the generated stub files that Squirrel makes |
erickzhao
reviewed
Feb 5, 2024
felixrieseberg
pushed a commit
to electron/windows-sign
that referenced
this pull request
Feb 29, 2024
In order to get electron/windows-installer#501 over the hump, I'll need `@electron/windows-sign` to install fine on Node 14. Turns out, we don't really need Node 16, so I'm just downgrading our requirements here. This is a non-breaking change.
VerteDinde
approved these changes
Mar 4, 2024
|
🎉 This PR is included in version 5.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables
@electron/windows-signto "hijack" codesigning within Squirrel. It does so by using@electron/windows-sign's ability to create a customsigntool.exethat's actually a "single executable application" built with Node.js, calling@electron/windows-signunderneath.This, in turn, allows developers to customize their codesigning pipelines - with custom tools, scripts, and even per-file configurations. Now that Windows will only accept EV Codesigning certificates, many developers are faced with codesigning scenarios that are more complex - involving custom tooling, cloud-based solutions, and other shenanigans.
For details on how this all works underneath the hood, check out electron/windows-sign@8b23eaa
Decision to not make this a breaking change
@electron/windows-installeronly requires Node.js >= 8.0.0.@electron/windows-signrequires Node.js >= 16.0.0.@electron/windows-sign's "fake signtool.exe" feature requires Node.js >= 18.0.0, the first version to contain the "single executable" feature.@electron/windows-installer. Instead,@electron/windows-signis an optional dependency - and if it didn't install, we'll throw a useful error only if people are trying to use the newwindowsSignparameter.