feat: Add a vendor directory option to use a custom vendor - #526
Merged
Conversation
added 2 commits
July 21, 2024 13:56
felixrieseberg
approved these changes
Jul 23, 2024
felixrieseberg
left a comment
Member
There was a problem hiding this comment.
@beyondkmp This is looking pretty good - and something that scares us maintainers a lot less than upgrading NuGet or 7-zip directly because letting people customize their vendors comes without any backwarts compat issues. We don't have any specific reason to suspect that either the 7Zip or NuGet upgrade would break anything, but then again, we haven't tested it either - and if they do break things, we'd rather not be on the hook for fixing it 😉 Your change here seems like a great solution!
Thank you!
(Note for others: Check out the changes without whitespace changes)
|
🎉 This PR is included in version 5.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doing this has two benefits: