Conversation
bkendall
reviewed
Oct 24, 2019
src/extensions/rolesHelper.ts
Outdated
| return member === `serviceAccount:${serviceAccountEmail}`; | ||
| }); | ||
| }); | ||
| policy.version = 3; |
Contributor
There was a problem hiding this comment.
Can getIamPolicy return a .version on its own? What would overwriting it here do?
There was a problem hiding this comment.
if it's a closed loop get-write-set, then the get with v3 will return version: 3.
outside mods that are a "blind set" can be done without a version: 3
I verified this with the IAM person (Ajay).
So I think we can remove version: 3 being forced here.
tstirrat
approved these changes
Oct 24, 2019
tstirrat
left a comment
tstirrat
left a comment
There was a problem hiding this comment.
Probably fine as is, but the version = 3 is redundant.
bkendall
requested changes
Oct 28, 2019
Contributor
bkendall
left a comment
bkendall
left a comment
There was a problem hiding this comment.
Add a small note to the changelog so we don't forget we did this:
* Specify version when dealing with IAM Policies related to Extensions.
Contributor
|
maybe change the title to "set" not "get and set"? |
bkendall
approved these changes
Oct 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Specifies schema version=3 on get and set IAM calls.
Scenarios Tested
I created and updated an instance of storage-resize-images, and confirmed that the IAM calls worked and set version=3.