Fix issue #5561 emulators not starting with vite#6411
Fix issue #5561 emulators not starting with vite#6411sotovviktor wants to merge 2 commits intofirebase:masterfrom sotovviktor:master
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #6411 +/- ##
==========================================
- Coverage 54.65% 54.65% -0.01%
==========================================
Files 347 347
Lines 23801 23803 +2
Branches 4893 4893
==========================================
+ Hits 13009 13010 +1
- Misses 9595 9596 +1
Partials 1197 1197 ☔ View full report in Codecov by Sentry. |
jamesdaniels
left a comment
There was a problem hiding this comment.
Add changelog entry and see about converting to an import statement and g2g
|
I addressed feedback in #6588 |
Description
Fixes #5561
stdout data on widnows has ANSI characters in the URL preventing resolution of the promise. This PR fixes it.