Skip to content

use build target in Vite builds#6643

Merged
leoortizz merged 8 commits intomasterfrom
leoortizz_vite-build-target
Jan 23, 2024
Merged

use build target in Vite builds#6643
leoortizz merged 8 commits intomasterfrom
leoortizz_vite-build-target

Conversation

@leoortizz
Copy link
Copy Markdown
Member

@leoortizz leoortizz commented Dec 26, 2023

Description

Scenarios Tested

Sample Commands
yykamei and others added 3 commits December 19, 2023 11:30
@yykamei @joehan
Use checkout@v4 for Firebase Hosting Preview GitHub Workflow (#6441)
d4e4b2d 
When starting a project with `firebase init` with GitHub Workflow,
YAML files were configured with `actions/checkout@v3` previously.

Now, `actions/checkout@v4` has been released,
the template should also be updated to specify the latest version.

https://github.com/actions/checkout/releases/tag/v4.0.0

Co-authored-by: joehan <joehanley@google.com>
@joehan
Support export in env parser (#6630)
e9773fb 
* Support export in env parser

* use a noncapture group
@leoortizz
use build target in vite builds
38cc13c
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 26, 2023 •
edited
Loading

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.18%. Comparing base (5f6c816) to head (17c8e25).
⚠️ Report is 1307 commits behind head on master.

Files with missing lines Patch % Lines
src/frameworks/sveltekit/index.ts 50.00% 1 Missing ⚠️
src/frameworks/vite/index.ts 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6643   +/-   ##
=======================================
  Coverage   54.18%   54.18%           
=======================================
  Files         347      347           
  Lines       24132    24132           
  Branches     4978     4978           
=======================================
  Hits        13075    13075           
  Misses       9856     9856           
  Partials     1201     1201

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@leoortizz leoortizz mentioned this pull request Dec 26, 2023
Merged
@leoortizz leoortizz changed the title use build target in vite builds Dec 26, 2023
@leoortizz leoortizz changed the base branch from next to master January 2, 2024 18:09
@leoortizz leoortizz self-assigned this Jan 4, 2024
@leoortizz leoortizz marked this pull request as ready for review January 4, 2024 18:44
@leoortizz leoortizz enabled auto-merge (squash) January 23, 2024 13:39
@leoortizz leoortizz disabled auto-merge January 23, 2024 13:39
@leoortizz leoortizz enabled auto-merge (squash) January 23, 2024 13:39
@leoortizz leoortizz merged commit 923edb7 into master Jan 23, 2024
@leoortizz leoortizz deleted the leoortizz_vite-build-target branch January 23, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment