replace NODE_ENV during Vite build#6644
Merged
Conversation
When starting a project with `firebase init` with GitHub Workflow, YAML files were configured with `actions/checkout@v3` previously. Now, `actions/checkout@v4` has been released, the template should also be updated to specify the latest version. https://github.com/actions/checkout/releases/tag/v4.0.0 Co-authored-by: joehan <joehanley@google.com>
* Support export in env parser * use a noncapture group
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #6644 +/- ##
==========================================
- Coverage 54.18% 54.17% -0.01%
==========================================
Files 347 347
Lines 24132 24135 +3
Branches 4978 4978
==========================================
Hits 13075 13075
- Misses 9856 9859 +3
Partials 1201 1201 ☔ View full report in Codecov by Sentry. |
jamesdaniels
approved these changes
Jan 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5962.
Closes #6041.
This PR also has 38cc13c from #6643 to have
targetinbuildScenarios Tested
Sample Commands