Skip to content

remove public directory from hosting emulator for frameworks#6674

Merged
leoortizz merged 10 commits intomasterfrom
leoortizz_publicDirFrameworkDev
Jan 23, 2024
Merged

remove public directory from hosting emulator for frameworks#6674
leoortizz merged 10 commits intomasterfrom
leoortizz_publicDirFrameworkDev

Conversation

@leoortizz
Copy link
Copy Markdown
Member

Description

Should fix #6377

Scenarios Tested

Sample Commands

@leoortizz leoortizz changed the title change public directory for frameworks dev server with emulator Jan 9, 2024
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 9, 2024

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.14%. Comparing base (d0972f7) to head (873b647).
⚠️ Report is 1235 commits behind head on master.

Files with missing lines Patch % Lines
src/frameworks/index.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6674      +/-   ##
==========================================
- Coverage   54.17%   54.14%   -0.03%     
==========================================
  Files         347      347              
  Lines       24135    24133       -2     
  Branches     4978     4978              
==========================================
- Hits        13075    13068       -7     
- Misses       9859     9863       +4     
- Partials     1201     1202       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@leoortizz leoortizz marked this pull request as ready for review January 9, 2024 18:27
@leoortizz leoortizz enabled auto-merge (squash) January 23, 2024 14:18
@leoortizz leoortizz merged commit 7717b83 into master Jan 23, 2024
@leoortizz leoortizz deleted the leoortizz_publicDirFrameworkDev branch January 23, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment