Skip to content

Prevent pinTags + minInstances from any functions, not just frameworks#6684

Merged
inlined merged 3 commits intomasterfrom
inlined.tag-pinning-min-instances
Jan 16, 2024
Merged

Prevent pinTags + minInstances from any functions, not just frameworks#6684
inlined merged 3 commits intomasterfrom
inlined.tag-pinning-min-instances

Conversation

@inlined
Copy link
Copy Markdown
Member

@inlined inlined commented Jan 12, 2024

We previously removed pinTags from the web frameworks configuration options because it is a foot gun, but customers could still hurt themselves if they turn on pinTags with a manual Function rewrite. This prevents the footgun at the API layer.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 12, 2024

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.18%. Comparing base (6b0cb5d) to head (e890289).
⚠️ Report is 1256 commits behind head on master.

Files with missing lines Patch % Lines
src/deploy/hosting/convertConfig.ts 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6684      +/-   ##
==========================================
- Coverage   54.18%   54.18%   -0.01%     
==========================================
  Files         347      347              
  Lines       24130    24132       +2     
  Branches     4976     4977       +1     
==========================================
  Hits        13075    13075              
- Misses       9855     9856       +1     
- Partials     1200     1201       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Copy link
Copy Markdown
Contributor

@Berlioz Berlioz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trepca
Copy link
Copy Markdown

trepca commented Feb 13, 2025

@inlined so how can I use minInstances for my webframework deployment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants