Add support for automated tests in App Distribution#6730
Merged
Conversation
6a98dca to
fd4fe15
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6730 +/- ##
==========================================
+ Coverage 54.25% 54.31% +0.05%
==========================================
Files 347 349 +2
Lines 24197 24283 +86
Branches 5005 5021 +16
==========================================
+ Hits 13129 13190 +61
- Misses 9866 9888 +22
- Partials 1202 1205 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
31df542 to
bbea92c
Compare
e6d5ee1 to
cd4c845
Compare
rebehe
approved these changes
Jan 31, 2024
9bed02b to
6fb713f
Compare
rebehe
reviewed
Jan 31, 2024
joehan
requested changes
Feb 5, 2024
Member
joehan
left a comment
There was a problem hiding this comment.
Code mostly looks good, with a few small style fixes suggested. However, this change needs an approved API proposal since it changes that public API of the CLI. I have some concerns about the API for this command that would be better discussed there. I couldn't find one at go/firebase-api-tracker - could you link one if I missed it, or start one up?
kaibolay
reviewed
Feb 5, 2024
2df6e0b to
9469c64
Compare
joehan
approved these changes
Feb 6, 2024
joehan
reviewed
Feb 6, 2024
ee32d10 to
c1f6d9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding
--test-devicesand related flags toappdistribution:distributeaction. This will trigger the new Automated Tester feature.Scenarios Tested
Sample Commands
firebase appdistribution:distribute --app <app id> <path> --test-devices <devices>firebase appdistribution:distribute --app <app id> <path> --test-devices <devices> --test-asyncfirebase appdistribution:distribute --app <app id> <path> --test-devices <devices> --test-username <user> --test-password <password>firebase appdistribution:distribute --app <app id> <path> --test-devices <devices> --test-username <user> --test-password <password> --test-username-resource <resource id> --test-password-resource <resource id>