Skip to content

prevent hosting API calls when using JS SDK with frameworks and demo project on emulators#6737

Merged
leoortizz merged 8 commits intomasterfrom
leoortizz_fixDemoProjectWithFrameworks
Feb 28, 2024
Merged

prevent hosting API calls when using JS SDK with frameworks and demo project on emulators#6737
leoortizz merged 8 commits intomasterfrom
leoortizz_fixDemoProjectWithFrameworks

Conversation

@leoortizz
Copy link
Copy Markdown
Member

Description

Fixes #6377

Scenarios Tested

Sample Commands

...with frameworks and demo project on emulators
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 2, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 54.22%. Comparing base (41922fe) to head (14bd1e6).

Files Patch % Lines
src/frameworks/index.ts 33.33% 4 Missing ⚠️
src/hosting/api.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6737      +/-   ##
==========================================
- Coverage   54.22%   54.22%   -0.01%     
==========================================
  Files         352      352              
  Lines       24488    24494       +6     
  Branches     5065     5067       +2     
==========================================
+ Hits        13278    13281       +3     
- Misses       9997    10000       +3     
  Partials     1213     1213              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamesdaniels
Copy link
Copy Markdown
Member

Add changelog, otherwise LGTM

@leoortizz leoortizz enabled auto-merge (squash) February 28, 2024 17:56
@leoortizz leoortizz merged commit 1fb1382 into master Feb 28, 2024
@leoortizz leoortizz deleted the leoortizz_fixDemoProjectWithFrameworks branch March 1, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment