Ignore quota project in GCF source uploads#6917
Merged
Conversation
joehan
approved these changes
Mar 26, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6917 +/- ##
==========================================
- Coverage 54.52% 54.50% -0.02%
==========================================
Files 353 353
Lines 24655 24660 +5
Branches 5095 5098 +3
==========================================
Hits 13442 13442
- Misses 9994 9998 +4
- Partials 1219 1220 +1 ☔ View full report in Codecov by Sentry. |
inlined
added a commit
that referenced
this pull request
Mar 27, 2024
* Ignore quota project in GCF source uploads * Changelog * Remove superfluous change * format + fix tests --------- Co-authored-by: Joe Hanley <joehanley@google.com>
inlined
added a commit
that referenced
this pull request
Mar 27, 2024
* Stop trying to clean up AR cache on function deletion. Since release of this feature, GCF has started cleaning up cache images automatically on function deletion. This has led to us getting 404 errors and printing scary messages in the console. Fixes #6882 * Ignore quota project in GCF source uploads (#6917) * Ignore quota project in GCF source uploads * Changelog * Remove superfluous change * format + fix tests --------- Co-authored-by: Joe Hanley <joehanley@google.com> * 13.6.0 * [firebase-release] Removed change log and reset repo after 13.6.0 release * Changelog * Remove dead code unit test --------- Co-authored-by: Joe Hanley <joehanley@google.com> Co-authored-by: Google Open Source Bot <firebase-oss-bot@google.com>
jdcoldsmith
reviewed
Mar 28, 2024
| if (process.env.GOOGLE_CLOUD_QUOTA_PROJECT) { | ||
| logLabeledWarning( | ||
| "functions", | ||
| "GOOGLE_CLOUD_QUTOA_PROJECT is not usable when uploading source for Cloud Functions.", |
Contributor
There was a problem hiding this comment.
Typo here. Should be "GOOGLE_CLOUD_QUOTA_PROJECT"
| if (process.env.GOOGLE_CLOUD_QUOTA_PROJECT) { | ||
| logLabeledWarning( | ||
| "functions", | ||
| "GOOGLE_CLOUD_QUTOA_PROJECT is not usable when uploading source for Cloud Functions.", |
Contributor
There was a problem hiding this comment.
Typo here. Should be "GOOGLE_CLOUD_QUOTA_PROJECT"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Best fix for #6896 that we can do for now. I strongly suspect that GCS just can't handle signed URL uploads with quota projects.