fix: add codebase config runtime to delegate context object#6964
Merged
inlined merged 7 commits intofirebase:masterfrom Apr 11, 2024
Merged
fix: add codebase config runtime to delegate context object#6964inlined merged 7 commits intofirebase:masterfrom
inlined merged 7 commits intofirebase:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Member
|
Looks good to me. Can you add a line to CHANGELOG.md saying: "Fixes bug detecting functions runtime from firebase.json (#6964)"? |
Contributor
Author
|
Added! 😄 |
Contributor
|
@luc-mo It looks like the linter failed, could you run |
Contributor
Author
|
Fixed 😄 |
inlined
approved these changes
Apr 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Recently, I encountered an issue that arose unexpectedly during the deployment of firebase functions. The error occurs due the
runtimefield is not recognized in thefirebase.jsonfile, thereby causing a failure in the deployment.Fixes #6973
Deployment log:
Scenarios Tested
I conducted tests by installing other versions of the package and attempting to deploy, coming to the conclusion that it was an error introduced in version 13.6.1 where the
runtimeproperty was removed from thedelegateContextobject declaration. The error does not occur in versions previous to 13.6.1.I performed the test by doing an
npm linkof firebase-tools package and deploying my functions manually. These were deployed successfully.Deployment log with changes: