sql:migrate --force shouldn't prompt

[fredzqm]

Description

firebase dataconnect:sql:migrate --force should never prompt.

firebase dataconnect:sql:migrate should prompt for schema migrations and then abort if there is invalid connectors. This way developers can see the SQL before taking the suggesting and run it with --force.

Scenarios Tested

Sample Commands

Without invalid connectors

firebase dataconnect:sql:migrate

firebase dataconnect:sql:migrate --force

With invalid connectors

firebase dataconnect:sql:migrate

firebase dataconnect:sql:migrate --force

[rosalyntan]

Since there's only two options now, should this return Promise<false | true>? Also does maybeExecuteSchemaMigration better describe what this method does?

[fredzqm]

This method doesn't execute schema migration. It determines whether to execute it later.

Well, keeping it as string merely because we will have a "compatible" mode soon. At least 3 value enum is needed here.

[fredzqm]

Thanks!

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 54.06%. Comparing base (c94b5ab) to head (1ab7ed2).
Report is 977 commits behind head on master.

Files with missing lines	Patch %	Lines
src/dataconnect/schemaMigration.ts	0.00%	10 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7208      +/-   ##
==========================================
- Coverage   54.10%   54.06%   -0.05%     
==========================================
  Files         387      386       -1     
  Lines       26094    26108      +14     
  Branches     5358     5361       +3     
==========================================
- Hits        14119    14115       -4     
- Misses      10715    10733      +18     
  Partials     1260     1260              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.