Make prettify more tolerant to missing fields.#7230
Merged
Conversation
Co-authored-by: joehan <joehanley@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes errors like this:
Scenarios Tested
A customer has encountered this when the error
connector source must not contain anonymous operationswas thown. The existing code fails during processing, and swallows the actual error. I guess these are indeed without file names or paths for now. We may need to improve the error reporting, but for now, the point is that errors like these do exist.This PR make sure when it happens again we will see the actual error message.
Sample Commands
firebase deploy