Make firebase init dataconnect not wait for Cloud SQL instances provision#7275
Merged
Make firebase init dataconnect not wait for Cloud SQL instances provision#7275
firebase init dataconnect not wait for Cloud SQL instances provision#7275Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7275 +/- ##
==========================================
- Coverage 54.06% 54.03% -0.04%
==========================================
Files 386 386
Lines 26137 26156 +19
Branches 5370 5378 +8
==========================================
+ Hits 14131 14133 +2
- Misses 10742 10759 +17
Partials 1264 1264 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran through the onboard flow today.
The existing output made me feel compelled to sit there and wait for
firebase initto finish.Though customers can totally start coding right away.
firebase init dataconnectnot waiting for Cloud SQL instance.state=failedcloud sql state. Currently, we show those as succeed, but it's actually completely busted and unusable.Scenarios Tested
firebase inittakes over a "fresh from console" service.It spits out a link to monitor Cloud SQL provision instead of a forever long spinner that drives developer away.
Then, rerun
firebase initwhile the Cloud SQL instance is being created.Then attempt

firebase deploywhile the Cloud SQL instance is being created.firebase initwhen Cloud SQL instance is in a failed state (ran into this while deleting and recreating the instance)