Set a reasonable default dataconnect generated SDK output path#7406
Merged
Set a reasonable default dataconnect generated SDK output path#7406
Conversation
maneesht
approved these changes
Jul 2, 2024
Contributor
maneesht
left a comment
maneesht
left a comment
There was a problem hiding this comment.
If you can wait for @cherylEnkidu and @dconeybe's reviews for Swift/Kotlin to cover all platforms, that'd be great
cherylEnkidu
approved these changes
Jul 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Provide a default output path within
.dataconnectfolder, so by default we don't check-in generated SDK.The existing behavior going through
firebase init dataconnect:sdkflow with the default option is horrendous bad...Scenarios Tested
Sample Commands