Skip to content

Pass down functions.ignore values in firebase.json to functions emulator#7414

Merged
joehan merged 3 commits intofirebase:masterfrom
dikatok:master
Jul 8, 2024
Merged

Pass down functions.ignore values in firebase.json to functions emulator#7414
joehan merged 3 commits intofirebase:masterfrom
dikatok:master

Conversation

@dikatok
Copy link
Copy Markdown
Contributor

@dikatok dikatok commented Jul 5, 2024

Pass down functions.ignore values in firebase.json to functions emulator so that supposedly ignored directories/files will not trigger reload.
@dikatok dikatok changed the title pass down ignore value and add to chokidar.watch Jul 5, 2024
@dikatok dikatok mentioned this pull request Jul 5, 2024
Closed
@dikatok
Copy link
Copy Markdown
Contributor Author

dikatok commented Jul 6, 2024

Whoops, apparently I forgot to checkout my new branch and committed the changes to the master branch of my fork, is that okay?
joehan
joehan approved these changes Jul 8, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Lgtm, but could you add an entry to changelog.md for this change?
@dikatok
Copy link
Copy Markdown
Contributor Author

dikatok commented Jul 8, 2024 •
edited
Loading

@joehan do you mean changelog.md in the root directory? is it supposed to be empty?

edit: ah is it reset on every release?

edit2: done
@joehan joehan merged commit 461c926 into firebase:master Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@dikatok @joehan