chore: update sharp version#7517
Merged
leoortizz merged 9 commits intofirebase:masterfrom Aug 6, 2024
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
leoortizz
reviewed
Aug 1, 2024
Member
leoortizz
left a comment
leoortizz
left a comment
There was a problem hiding this comment.
LGTM! Just add changelog then we can merge. Thanks!
… into update-sharp-version
Contributor
Author
Done! |
leoortizz
reviewed
Aug 3, 2024
Co-authored-by: Leonardo Ortiz <leo@monogram.io>
leoortizz
approved these changes
Aug 5, 2024
leoortizz
requested changes
Aug 5, 2024
auto-merge was automatically disabled
August 6, 2024 13:40
Head branch was pushed to by a user without write access
Co-authored-by: Leonardo Ortiz <leo@monogram.io>
leoortizz
approved these changes
Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updating sharp version to address issue related on issue: #7346
Sharp version needs to be updated in two places, there is already a PR on the other repo:
firebase/apphosting-adapters#227
Scenarios Tested
Ran tests locally for Next.js 12 to 14 and Angular 14 to 17.
Also running locally with the updated sharp version from this PR: firebase/apphosting-adapters#227 for firebase-framework.
Sample Commands
N/A