Skip to content

update data connect client, dataplaneclient, and emulator client to v…#7589

Merged
hlshen merged 7 commits intomasterfrom
hlshen/v1beta
Sep 18, 2024
Merged

update data connect client, dataplaneclient, and emulator client to v…#7589
hlshen merged 7 commits intomasterfrom
hlshen/v1beta

Conversation

@hlshen
Copy link
Copy Markdown
Contributor

@hlshen hlshen commented Aug 23, 2024

Do not release until emulator updates endpoints

@hlshen hlshen requested a review from joehan August 23, 2024 17:47
@hlshen hlshen marked this pull request as draft August 23, 2024 19:33
Copy link
Copy Markdown
Member

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests in dataconnect/client.spec.ts are failing - looks like you just need to update the references to v1alpha in there as well.

@hlshen hlshen requested a review from joehan September 3, 2024 16:52
@hlshen hlshen marked this pull request as ready for review September 3, 2024 16:52
@hlshen hlshen merged commit c222f52 into master Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants