Skip to content

Add OOB flow for VERIFY_AND_CHANGE_EMAIL#7618

Merged
joehan merged 2 commits intofirebase:masterfrom
naoina:verify_and_change_email
Sep 10, 2024
Merged

Add OOB flow for VERIFY_AND_CHANGE_EMAIL#7618
joehan merged 2 commits intofirebase:masterfrom
naoina:verify_and_change_email

Conversation

@naoina
Copy link
Copy Markdown
Contributor

@naoina naoina commented Sep 2, 2024

Description

Implement VERIFY_AND_CHANGE_EMAIL OOB flow to accounts:sendOobCode API in Firebase Emulator. This changes allows you to use verifyBeforeUpdateEmail in Firebase Javascript SDK, generateVerifyAndChangeEmailLink in Firebase Admin SDK and accounts:sendOobCode API with requestType VERIFY_AND_CHANGE_EMAIL as well.

Refs #3424

Scenarios Tested

  • Tested the default handler for verifyAndChangeEmail mode by accessing the URL returned from generateVerifyAndChangeEmailLink
  • Tested the custom email handler using checkActionCode and applyActionCode of firebase/auth
Copy link
Copy Markdown
Member

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! LGTM, but I'd like @aalej to review as well, since he's done some work in this area of the codebase recently.

@joehan joehan requested a review from aalej September 3, 2024 22:32
Copy link
Copy Markdown
Contributor

@aalej aalej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! Thanks for submitting a PR! Tested using https://github.com/aalej/pull-7618/tree/main and it looks like the behavior in the emulator matches the one in prod. @joehan, this looks like a new feature, we might need to find someone from Auth team to review this as well.

@joehan joehan enabled auto-merge (squash) September 10, 2024 05:16
@joehan joehan disabled auto-merge September 10, 2024 15:55
@joehan joehan merged commit 19b5f49 into firebase:master Sep 10, 2024
@naoina naoina deleted the verify_and_change_email branch September 11, 2024 04:25
tammam-g pushed a commit that referenced this pull request Sep 13, 2024
Co-authored-by: joehan <joehanley@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants