Moving the emulator UI server to firebase-tools.#7897
Merged
christhompsongoogle merged 16 commits intomasterfrom Nov 13, 2024
Merged
Moving the emulator UI server to firebase-tools.#7897christhompsongoogle merged 16 commits intomasterfrom
christhompsongoogle merged 16 commits intomasterfrom
Conversation
![github-advanced-security[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
yuchenshi
requested changes
Nov 7, 2024
yuchenshi
approved these changes
Nov 12, 2024
Member
yuchenshi
left a comment
yuchenshi
left a comment
There was a problem hiding this comment.
Approach looks good. One nit inline. Please run npm run fmt to fix linter errors
Comment on lines
+80
to
+82
| app.get("*", (_, res) => { | ||
| res.sendFile(path.join(webDir, "index.html")); | ||
| }); |
Check failure
Code scanning / CodeQL
Missing rate limiting
yuchenshi
approved these changes
Nov 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the server.ts file to firebase-tools so that the emulator UI can be served in-process with the firebase CLI.
Some questions are inline with the code (marked with "FIXME") for second opinions