Conversation
joehan
approved these changes
Dec 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8019 +/- ##
==========================================
- Coverage 51.19% 51.18% -0.01%
==========================================
Files 423 423
Lines 29544 29547 +3
Branches 6031 6032 +1
==========================================
Hits 15125 15125
- Misses 13059 13062 +3
Partials 1360 1360 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue only affected python functions because Flask by default will return status=415 when making POST request with JSON body without content-type header. Express server wrapping Nodejs functions, on the other hand, is more loosey-goosey when it comes to validating incoming request headers.
Fixes #7998