Skip to content

Fix issue where content-type headers were not sent to event functions.#8019

Merged
taeold merged 3 commits intomasterfrom
dl-events
Dec 3, 2024
Merged

Fix issue where content-type headers were not sent to event functions.#8019
taeold merged 3 commits intomasterfrom
dl-events

Conversation

@taeold
Copy link
Copy Markdown
Contributor

@taeold taeold commented Dec 3, 2024

This issue only affected python functions because Flask by default will return status=415 when making POST request with JSON body without content-type header. Express server wrapping Nodejs functions, on the other hand, is more loosey-goosey when it comes to validating incoming request headers.

Fixes #7998

@taeold taeold requested a review from joehan December 3, 2024 00:45
@taeold taeold enabled auto-merge (squash) December 3, 2024 00:49
@taeold taeold merged commit eb5c922 into master Dec 3, 2024
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.18%. Comparing base (49c5ac5) to head (1db1a61).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8019      +/-   ##
==========================================
- Coverage   51.19%   51.18%   -0.01%     
==========================================
  Files         423      423              
  Lines       29544    29547       +3     
  Branches     6031     6032       +1     
==========================================
  Hits        15125    15125              
- Misses      13059    13062       +3     
  Partials     1360     1360              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants