Conversation
chalosalvador
approved these changes
Mar 7, 2025
Member
chalosalvador
left a comment
chalosalvador
left a comment
There was a problem hiding this comment.
LGTM! Thanks @leoortizz and @aalej for working on this 💯
leoortizz
force-pushed
the
leoortiz_deployFix
branch
from
5090422 to
6bdd090
Compare
leoortizz
commented
Mar 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8274.
Thanks @aalej for nailing down the issue and providing a MCVE.
Scenarios Tested
firebase deploywith and withoutsiteinfirebase.jsonfirebase deploywith and without--onlyfirebase deploywith and without web frameworksSample Commands
firebase deploy