[BREAKING(apphosting)] Deprecate apphosting.local.yaml in favor of apphosting.emulator.yaml#8361
Merged
[BREAKING(apphosting)] Deprecate apphosting.local.yaml in favor of apphosting.emulator.yaml#8361
Conversation
taeold
approved these changes
Mar 25, 2025
| if ("value" in env[name]) { | ||
| const newValue = await prompt.promptOnce({ | ||
| type: "input", | ||
| message: `What new value would you like for plaintext ${name}?`, |
Contributor
There was a problem hiding this comment.
wondering if default should be current value as a means. to show users what the value currently is.
src/apphosting/config.ts
Outdated
| secretRef = await prompt.promptOnce({ | ||
| type: "input", | ||
| message: `What would you like to name the secret reference for ${name}?`, | ||
| // TODO: kebab case + test |
Member
Author
There was a problem hiding this comment.
Actually fixed it and forgot to remove the TODO 😆
annajowang
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
projectId may become necessary, depending on some changes @jamesdaniels is looking at, but this should all be forwards compatible with these changes.