Skip to content

Keep artifact registry dry run off for policy changes#8419

Merged
colerogers merged 3 commits intomasterfrom
colerogers.fix-dry-run-policy
Apr 14, 2025
Merged

Keep artifact registry dry run off for policy changes#8419
colerogers merged 3 commits intomasterfrom
colerogers.fix-dry-run-policy

Conversation

@colerogers
Copy link
Copy Markdown
Contributor

Fixes #8418

It seems that the Repository resource has the field cleanupPolicyDryRun set to true by default on the GCF repos. This change fixes forces that field to be false when using the firebase functions:artifacts:setpolicy command.

Copy link
Copy Markdown
Contributor

@taeold taeold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow great catch 😭

@colerogers colerogers enabled auto-merge (squash) April 14, 2025 17:13
@colerogers colerogers merged commit 6f083bc into master Apr 14, 2025
48 of 49 checks passed
blidd-google pushed a commit that referenced this pull request May 12, 2025
* fix to unset the boolean cleanupPolicyDryRun on ar repos

* adding changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants