Skip to content

[FDC] Generate schema during init dataconnect flow#8596

Merged
fredzqm merged 50 commits intomasterfrom
fz/gen-schema-init
Jun 23, 2025
Merged

[FDC] Generate schema during init dataconnect flow#8596
fredzqm merged 50 commits intomasterfrom
fz/gen-schema-init

Conversation

@fredzqm
Copy link
Copy Markdown
Contributor

@fredzqm fredzqm commented May 15, 2025

Added ToS note as well

Screenshot 2025-06-23 at 11 23 12 AM
@@ -111,7 +112,7 @@ export async function askQuestions(setup: Setup): Promise<void> {
}));
if (shouldConfigureBackend) {
// TODO: Prompt for app idea and use GiF backend to generate them.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove TODO?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, removed

@github-project-automation github-project-automation bot moved this to Changes Requested [PR] in [Cloud] Extensions + Functions May 15, 2025
@fredzqm
Copy link
Copy Markdown
Contributor Author

fredzqm commented May 15, 2025

Addressed all feedbacks~

@fredzqm fredzqm changed the base branch from master to fz/show-gif-tos May 29, 2025 21:42
@fredzqm fredzqm force-pushed the fz/show-gif-tos branch 2 times, most recently from e5ad926 to 3e2d5f7 Compare May 29, 2025 22:29
Base automatically changed from fz/show-gif-tos to master May 30, 2025 00:18
if (
setup.projectId &&
(await confirm({
message: `Do you want Gemini to help generate a schema for your service?`,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Do you want Gemini in Firebase to help generate a schema for your service"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done~

@fredzqm fredzqm marked this pull request as ready for review June 23, 2025 18:23
@fredzqm
Copy link
Copy Markdown
Contributor Author

fredzqm commented Jun 23, 2025

This PR is ready for review as well. Now that Turbo is approved.

@joehan 🙏

@fredzqm fredzqm requested a review from joehan June 23, 2025 18:59
Copy link
Copy Markdown
Member

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-project-automation github-project-automation bot moved this from Changes Requested [PR] to Approved [PR] in [Cloud] Extensions + Functions Jun 23, 2025
@fredzqm fredzqm merged commit d4dcf16 into master Jun 23, 2025
50 checks passed
@fredzqm fredzqm deleted the fz/gen-schema-init branch June 23, 2025 19:42
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants