Conversation
joehan
approved these changes
May 15, 2025
fredzqm
reviewed
May 15, 2025
fredzqm
reviewed
May 15, 2025
fredzqm
approved these changes
May 15, 2025
fredzqm
approved these changes
May 22, 2025
Contributor
fredzqm
left a comment
There was a problem hiding this comment.
LG since we are exiting code freeze.
joehan
approved these changes
May 22, 2025
Member
joehan
left a comment
There was a problem hiding this comment.
Code LGTM - but should we enable this tool when you enable app hosting tools too?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8605 +/- ##
==========================================
+ Coverage 51.04% 51.07% +0.02%
==========================================
Files 431 431
Lines 30986 31015 +29
Branches 6367 6371 +4
==========================================
+ Hits 15818 15840 +22
- Misses 13752 13760 +8
+ Partials 1416 1415 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TrCaM
pushed a commit
that referenced
this pull request
May 26, 2025
* initial apphosting mcp tool * add fetchServiceLogs function * add run tool to fetch logs * add a little more description for location * cleaning up logic a bit * add new tools to smoke test * don't reinvent the cloud run logs wheel * back out cloud run tool * creates a new logs helper for app hosting for both build and runtime logs * lint issues * some funny business got into my code. undoing it * add changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an initial MCP tool for App Hosting.
This combines the Backend and it's singleton Traffic resource into one so that the LLM can make some inferences about the traffic information!
It also adds a tool so that it can fetch build or service logs!
Scenarios Tested
Sample Commands