fix: only show runtime config deprecation warning for user-defined config#8963
fix: only show runtime config deprecation warning for user-defined config#8963
Conversation
![gemini-code-assist[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @taeold, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses an issue where users were receiving false positive deprecation warnings for functions.config() even when they were not actively using runtime configuration. The change introduces a condition to the warning mechanism, ensuring that the deprecation notice is only shown when a user has explicitly defined runtime configuration values, thereby improving the user experience by reducing unnecessary warnings.
Highlights
- Conditional Deprecation Warning: The logic for issuing the
functions.config()deprecation warning has been updated. It now includes a check to ensure the warning is only displayed if theruntimeConfigobject contains keys beyond the default 'firebase' key, indicating actual user-defined configuration.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request addresses an issue where deprecation warnings for runtime config were shown incorrectly. The change introduces a check to only display the warning if the user has defined their own configuration, besides the default Firebase config. The logic is correct, but I've suggested a small refactoring to improve code readability and conciseness.
…nfig The runtime config deprecation warning was appearing for all v1 function deployments, even when users weren't using functions.config(). This was because the default Firebase config values (projectId, storageBucket) are always included in the runtime config. This fix checks if the runtime config contains any keys beyond the default 'firebase' key before showing the deprecation warning. Users who only have the default Firebase config will no longer see false positive warnings. Fixes #8925
taeold
force-pushed
the
fix-runtime-config-false-positive-warning
branch
from
d5cf23b to
5ddec29
Compare
Use Object.keys().some() directly for cleaner, more readable code
github-project-automation
bot
moved this to Approved [PR]
in [Cloud] Extensions + Functions
github-project-automation
bot
moved this from Approved [PR]
to Done
in [Cloud] Extensions + Functions
|
Thanks for this, when there will be a version with this change available @taeold ? |
…nfig (#8963) * fix: only show runtime config deprecation warning for user-defined config The runtime config deprecation warning was appearing for all v1 function deployments, even when users weren't using functions.config(). This was because the default Firebase config values (projectId, storageBucket) are always included in the runtime config. This fix checks if the runtime config contains any keys beyond the default 'firebase' key before showing the deprecation warning. Users who only have the default Firebase config will no longer see false positive warnings. Fixes #8925 * docs: add CHANGELOG entry for runtime config warning fix * chore: update runtime config deprecation date to March 2026 * refactor: simplify runtime config user check logic Use Object.keys().some() directly for cleaner, more readable code
3 participants
Summary
Fixes false positive deprecation warnings for users who aren't using
functions.config()and updates deprecation timeline.Problem
Users were seeing runtime config deprecation warnings even without using Runtime Config, because the default Firebase config (
projectId,storageBucket) is always present for v1 functions.Solution
firebasekeyTest plan
Fixes #8925