Remove connectionTimeoutMillis from pool options

[fredzqm]

Description

Discussions suggested that we introduced a regression since 14.17.0
#9314 (comment)

The timeout was added in #9200. The only change to connect.ts since 14.17.0.

Scenarios Tested

Sample Commands

[gemini-code-assist]

Summary of Changes

Hello @fredzqm, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a reported regression by reverting a recent change that introduced a specific connection timeout setting. By removing the connectionTimeoutMillis option from the PostgreSQL connection pool configuration, the aim is to resolve connection stability issues that users might have encountered since version 14.17.0, thereby improving the reliability of Cloud SQL connections.

Highlights

• Connection Timeout Removal: The connectionTimeoutMillis option has been removed from the pg.Pool configuration in src/gcp/cloudsql/connect.ts.
• Regression Fix: This change is intended to resolve a regression introduced in version 14.17.0, which was causing connection issues as discussed in a related GitHub issue.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a regression by removing the connectionTimeoutMillis setting from the PostgreSQL connection pool options. By reverting to the default behavior of node-postgres (which has no timeout for acquiring a connection), this change should resolve the connection issues introduced by the explicit 1-second timeout. The change is simple, targeted, and appears to be the correct fix for the described problem.