Conversation
Summary of ChangesHello @itsrakhil, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on upgrading the Firebase Data Connect emulator to its latest patch version, Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Data Connect emulator to version 3.1.1. The changes involve updating the emulator's version, checksums, and download URLs in the configuration, and adding an entry to the changelog. The changes are straightforward and appear correct for a release. I have one minor suggestion for the CHANGELOG.md file to adhere to common text file conventions.
CHANGELOG.md
Outdated
| - Added `firebase dataconnect:compile` command. | ||
| - Loads experiments earlier in CLI startup so they can be used earlier. (#9797) | ||
| - Fixed issue where Storage security rules is overwritten when running `firebase init storage`. (#8170) | ||
| - Updated to v3.1.1 of the Data Connect emulator which includes fixed and internal improvements. (#9835) |
There was a problem hiding this comment.
It's a good practice for text files to end with a single newline character. This can prevent issues with some tools and file processing scripts.
| - Updated to v3.1.1 of the Data Connect emulator which includes fixed and internal improvements. (#9835) | |
| - Updated to v3.1.1 of the Data Connect emulator which includes fixed and internal improvements. (#1111) | |
References
- Text files should end with a newline character. This is a standard convention (e.g., in POSIX) for text files to ensure they can be processed correctly by various tools. (link)
CHANGELOG.md
Outdated
| - Added `firebase dataconnect:compile` command. | ||
| - Loads experiments earlier in CLI startup so they can be used earlier. (#9797) | ||
| - Fixed issue where Storage security rules is overwritten when running `firebase init storage`. (#8170) | ||
| - Updated to v3.1.1 of the Data Connect emulator which includes fixed and internal improvements. (#9835) |
There was a problem hiding this comment.
Remove misleading MISSING_JOIN_TABLE_KEY when @table(key) has 3 columns. Fix #9762
Surface accurate GraphQL error code and path.
4 participants
Description
Scenarios Tested
Sample Commands
Fix #9762