Add support for RF64 wave files#9543
Conversation
kim-vde
left a comment
kim-vde
left a comment
There was a problem hiding this comment.
It would be great if you could add a unit test for RF64 in WavExtractorTest! Is it possible to generate a RF64 file that is fairly small in size (ideally less than 100KB)?
...ary/extractor/src/main/java/com/google/android/exoplayer2/extractor/wav/WavHeaderReader.java
Outdated
Show resolved
Hide resolved
|
I added a unit test and fixed a bug i found along the way. |
| } | ||
|
|
||
| @Test | ||
| public void sample_RF64() throws Exception { |
There was a problem hiding this comment.
You also need to generate the dump files that go with the test. To do so, you need to,
- Set DUMP_FILE_ACTION to WRITE_TO_LOCAL in DumpFileAsserts.java
- Run the test. This will create dump files that are a summary of the data extracted by the WavExtractor.
- Set DUMP_FILE_ACTION back to COMPARE_WITH_EXISTING.
- Run the test. This will compare the extracted data with the files previously generated. This test need to pass.
There was a problem hiding this comment.
Just added the dump files and the test is passing :)
...ary/extractor/src/main/java/com/google/android/exoplayer2/extractor/wav/WavHeaderReader.java
Outdated
Show resolved
Hide resolved
This refactoring is the basis to support RF64 (see Issue: #9543). #minor-release PiperOrigin-RevId: 406377924
|
I don't know why its saying there is a conflicting file. There shouldn't be because I have rebased my branch on the latest dev-v2 commit. |
|
Hey! I am currently working on merging this PR. I had to make some refactorings to make the code 100% correct. You don't need to do anything. The code PR should be merged in the following days/weeks. |
This refactoring is the basis to support RF64 (see Issue: #9543). #minor-release PiperOrigin-RevId: 407301056
This refactoring is the basis to support RF64 (see Issue: #9543). #minor-release PiperOrigin-RevId: 407301056
This refactoring is the basis to support RF64 (see Issue: google/ExoPlayer#9543). #minor-release PiperOrigin-RevId: 406377924
This refactoring is the basis to support RF64 (see Issue: google/ExoPlayer#9543). #minor-release PiperOrigin-RevId: 407301056
3 participants
This commit adds support for RF64 wave files without breaking the existing support for RIFF wave files