Skip to content

Commit 1adf867

Browse files
authored
fix: Async logging should not rethrow error in onFailure callback (#923)
1 parent 7f7f488 commit 1adf867

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

‎google-cloud-logging/src/main/java/com/google/cloud/logging/LoggingImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -882,7 +882,7 @@ public void flush() {
882882
try {
883883
ApiFutures.allAsList(writesToFlush).get(FLUSH_WAIT_TIMEOUT_SECONDS, TimeUnit.SECONDS);
884884
} catch (InterruptedException | ExecutionException | TimeoutException e) {
885-
throw new RuntimeException(e);
885+
System.err.println("ERROR: flush failure: " + e);
886886
}
887887
}
888888

0 commit comments

Comments
 (0)