Skip to content

feat: allow case_when to change dtypes if case list contains the condition True #1311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jan 28, 2025
Merged

feat: allow case_when to change dtypes if case list contains the condition True #1311

merged 14 commits into from
Jan 28, 2025

Conversation

rey-esp
Copy link
Contributor

@rey-esp rey-esp commented Jan 22, 2025 •
edited by tswast
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 349926559 🦕
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jan 22, 2025
tswast
tswast reviewed Jan 22, 2025
View reviewed changes
@rey-esp rey-esp requested a review from tswast January 22, 2025 23:51
tswast
tswast reviewed Jan 28, 2025
View reviewed changes
tswast
tswast approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@tswast tswast marked this pull request as ready for review January 28, 2025 17:18
@tswast tswast requested review from a team as code owners January 28, 2025 17:18
@tswast tswast requested a review from shuoweil January 28, 2025 17:18
tswast
tswast reviewed Jan 28, 2025
View reviewed changes
tswast
tswast reviewed Jan 28, 2025
View reviewed changes
@tswast tswast merged commit 5c2a2c6 into main Jan 28, 2025
21 of 22 checks passed
@tswast tswast deleted the b349926559-case-when branch January 28, 2025 18:36
@release-please release-please bot mentioned this pull request Jan 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
3 participants
@rey-esp @tswast @Genesis929