Skip to content

deps: support a shapely versions 1.8.5+ #1621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025
Merged

deps: support a shapely versions 1.8.5+ #1621

merged 1 commit into from
Apr 16, 2025

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Apr 16, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards internal issue 319116851 🦕

@tswast tswast requested review from a team as code owners April 16, 2025 17:19
@tswast tswast requested a review from shobsi April 16, 2025 17:19
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Apr 16, 2025
@tswast
Copy link
Collaborator Author

tswast commented Apr 16, 2025

e2e failure: FAILED tests/system/large/blob/test_function.py::test_blob_pdf_chunk[False-expected1]

prefetch_first = True

    @functools.wraps(callable_)
    def error_remapped_callable(*args, **kwargs):
        try:
            result = callable_(*args, **kwargs)
            # Auto-fetching the first result causes PubSub client's streaming pull
            # to hang when re-opening the stream, thus we need examine the hacky
            # hidden flag to see if pre-fetching is disabled.
            # [https://github.com/googleapis/python-pubsub/issues/93#issuecomment-630762257](https://www.google.com/url?q=https://github.com/googleapis/python-pubsub/issues/93%23issuecomment-630762257&sa=D)
            prefetch_first = getattr(callable_, "_prefetch_first_result_", True)
            return _StreamingResponseIterator(
                result, prefetch_first_result=prefetch_first
            )
        except grpc.RpcError as exc:
>           raise exceptions.from_grpc_error(exc) from exc
E           google.api_core.exceptions.InternalServerError: 500 there was an error operating on 'projects/bigframes-load-testing/locations/us/sessions/CAISDF9SV295Q2hnWUkxSRoCaXcaAmly/streams/GgJpdxoCaXIoAg': internal error

Looks like a flake on the BQ Storage Read API, unrelated to this change.

@tswast
Copy link
Collaborator Author

tswast commented Apr 16, 2025

notebook failure: notebooks/ml/bq_dataframes_ml_cross_validation.ipynb

https://github.com/googleapis/python-bigquery-dataframes/blob/main/notebooks/ml/bq_dataframes_ml_cross_validation.ipynb doesn't hit any geo columns, so I don't think that's related, either.

@tswast
Copy link
Collaborator Author

tswast commented Apr 16, 2025

presubmit failures look like LLM-related flakes. I'll hit retry on those.

FAILED tests/system/small/ml/test_preprocessing.py::test_min_max_scaler_normalized_fit_transform
FAILED tests/system/small/ml/test_llm.py::test_gemini_text_generator_multi_cols_predict_success[gemini-1.5-flash-001]
FAILED tests/system/small/ml/test_llm.py::test_gemini_text_generator_multi_cols_predict_success[gemini-1.5-flash-002]
FAILED tests/system/small/ml/test_preprocessing.py::test_min_max_scaler_series_normalizes
@tswast tswast enabled auto-merge (squash) April 16, 2025 17:57
@tswast tswast merged commit e39ee3b into main Apr 16, 2025
22 of 24 checks passed
@tswast tswast deleted the b319116851-shapely branch April 16, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
3 participants