Skip to content

feat: _read_gbq_colab creates hybrid session #1901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 24, 2025
Merged

feat: _read_gbq_colab creates hybrid session #1901

merged 6 commits into from
Jul 24, 2025

Conversation

TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
@TrevorBergeron TrevorBergeron requested a review from tswast July 11, 2025 17:36
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jul 11, 2025
@TrevorBergeron TrevorBergeron marked this pull request as ready for review July 11, 2025 18:28
@TrevorBergeron TrevorBergeron requested review from a team as code owners July 11, 2025 18:28
@tswast
Copy link
Collaborator

tswast commented Jul 14, 2025

Let's wait for the benchmarks to run at least once before this change before merging it.
@GarrettWu GarrettWu removed their assignment Jul 17, 2025
@shuoweil shuoweil added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 17, 2025
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 17, 2025
@TrevorBergeron
Copy link
Contributor Author

Let's wait for the benchmarks to run at least once before this change before merging it.

changed to be disabled by default, but able to easily be switched by caller
tswast
tswast reviewed Jul 22, 2025
View reviewed changes
bigframes/pandas/io/api.py Outdated
@@ -279,6 +279,7 @@ def _read_gbq_colab( # type: ignore[overload-overlap]
*,
pyformat_args: Optional[Dict[str, Any]] = ...,
dry_run: Literal[False] = ...,
use_hybrid_engine: bool = ...,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect you'll get unit tests failing because this parameter is in bigframes.pandas but not the session.

Now that we have the benchmarks going again, I think it'd be safe to remove the parameter.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok ,reverted
@TrevorBergeron TrevorBergeron requested a review from tswast July 23, 2025 00:08
@tswast
Copy link
Collaborator

tswast commented Jul 24, 2025

e2e failures

FAILED tests/system/large/blob/test_function.py::test_blob_transcribe[gemini-2.0-flash-lite-001-True]
FAILED tests/system/large/streaming/test_pubsub.py::test_streaming_df_to_pubsub

are unrelated.
@TrevorBergeron TrevorBergeron merged commit 31b17b0 into main Jul 24, 2025
23 of 25 checks passed
@TrevorBergeron TrevorBergeron deleted the colab_hybrid branch July 24, 2025 21:36
@release-please release-please bot mentioned this pull request Jul 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
5 participants
@TrevorBergeron @tswast @GarrettWu @bigframes-bot @shuoweil