Fix creating temporary files with open_basedir restrictions.

if tempnam() is called with an empty first parameter, open_basedir
restrictions set in. Use Horde_Util::getTempFile() consistently, and
make sure that it always uses a valid temporary directory.

Author: yunosh

lib/Horde/Text/Diff/Engine/Shell.php

@@ -36,8 +36,8 @@ public function diff($from_lines, $to_lines)
         array_walk($to_lines, array('Horde_Text_Diff', 'trimNewlines'));
 
         // Execute gnu diff or similar to get a standard diff file.
-        $from_file = tempnam(null, 'Horde_Text_Diff');
-        $to_file = tempnam(null, 'Horde_Text_Diff');
+        $from_file = Horde_Util::getTempFile('Horde_Text_Diff');
+        $to_file = Horde_Util::getTempFile('Horde_Text_Diff');
         $fp = fopen($from_file, 'w');
         fwrite($fp, implode("\n", $from_lines));
         fclose($fp);

package.xml

@@ -29,7 +29,7 @@
  </stability>
  <license uri="http://opensource.org/licenses/lgpl-license.php">LGPL</license>
  <notes>
-* 
+* [jan] Fix creating temporary files with open_basedir restrictions.
  </notes>
  <contents>
   <dir baseinstalldir="/" name="/">
@@ -279,7 +279,7 @@
    <date>2011-04-06</date>
    <license uri="http://opensource.org/licenses/lgpl-license.php">LGPL</license>
    <notes>
-* 
+* [jan] Fix creating temporary files with open_basedir restrictions.
    </notes>
   </release>
  </changelog>