Skip to content

fix: check the options scopes are not empty when getting access token#3256

Merged
musale merged 6 commits intomainfrom
fix/ignore-empty-option-scopes
Jul 22, 2024
Merged

fix: check the options scopes are not empty when getting access token#3256
musale merged 6 commits intomainfrom
fix/ignore-empty-option-scopes

Conversation

@musale
Copy link
Copy Markdown
Contributor

@musale musale commented Jul 16, 2024

Closes #3235

PR Type

  • Bugfix

Description of the changes

Check if the options.scopes are empty and default to the set scopes.

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@musale musale requested a review from a team as a code owner July 16, 2024 08:41
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@musale musale requested a review from Mnickii July 18, 2024 17:29
@musale musale merged commit 432d8ce into main Jul 22, 2024
@musale musale deleted the fix/ignore-empty-option-scopes branch July 22, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants