chore: Update Node support in README #3861
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't match the engines field, we support |
|
How would you recommend expressing this? I just followed what was used before. Would something like this work: One of the following versions of [Node.js](https://nodejs.org/en/download/) must be installed to run this program:
* 12.13.0 or higher
* 14.15.0 or higher
* 16.0.0 or higher |
|
I think that's a marked improvement on that section as a whole. |
|
I'd probably emphasize that 13 and 15 are not supported, either by clarifying the 12 and 14 ranges, or just adding a note. |
|
@wraithgar @ljharb: I updated the |
wraithgar
approved these changes
Oct 11, 2021
wraithgar
pushed a commit
that referenced
this pull request
Oct 11, 2021
xref: #3762 PR-URL: #3861 Credit: @gfyoung Close: #3861 Reviewed-by: @wraithgar
|
This is now in the readme, not sure why this PR didn't go purple. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: #3762