fix: allow --lockfile-version config to be string and coerce to number
#3949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacs
approved these changes
Oct 27, 2021
|
It's slightly unfortunate that it ends up showing the available values twice in the docs, but it's a tiny nit, and we can address that with the npm v9 config refactor. |
As all CLI input is considered to be string, eg. a "npm install --lockfile-version 3" would fail with the error messages: ``` npm WARN invalid config lockfile-version="3" set in command line options npm WARN invalid config Must be one of: null, 1, 2, 3 ``` Until we have a config system that supports setting type and possible values of configs, we have to specify all string and number values for the `lockfile-version`, but we coerce all values to numbers in the flattener. Co-authored-by: @voxpelli Co-authored-by: @isaacs PR-URL: #3949 Credit: @lukekarrys Close: #3949 Reviewed-by: @isaacs
lukekarrys
force-pushed
the
lk/config-lockfile-version
branch
from
b2c01ea to
cb9f435
Compare
Merged
|
It seems that |
1 task
ferferga
added a commit
to jellyfin/jellyfin-vue
that referenced
this pull request
Dec 13, 2021
ThibaultNocchi
pushed a commit
to jellyfin/jellyfin-vue
that referenced
this pull request
Dec 13, 2021
ferferga
added a commit
to jellyfin/jellyfin.org
that referenced
this pull request
Sep 6, 2022
* Also enforces a minimum version of 16.13.1 to avoid issues with lockfile v3: npm/cli#3949
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As all CLI input is considered to be string, eg. a
"npm install --lockfile-version 3" would fail with the error messages:
Until we have a config system that supports setting type and possible values
of configs, we have to specify all string and number values for the
lockfile-version, but we coerce all values to numbers in the flattener.Co-authored-by: @voxpelli
Co-authored-by: @isaacs