Ability to mark a comment as optional #16278
Unanswered
starkej2
asked this question in
Pull Requests
Replies: 1 comment
-
|
Hey 🙂 One question though: would this work best as a per-comment flag or a per-review mode? Some teams might want optional comments by default, while others only occasionally. Native support could standardize what today is just team convention. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
When reviewing a pull request, I often find myself leaving comments that are optional or nice-to-haves. This type of comment is usually best left to the author's discretion about whether to apply the suggested changes before merging the PR.
GitHub doesn't currently provide any functionality to differentiate between an optional vs required code review comment, so as a workaround my team typically includes prefixes/emoji such as
Optional:,Nitpick:,💡, etc to provide this additional context.It would be really helpful if GitHub pull requests provided a mechanism like an
Optionalcheckbox orComment Typedropdown to allow the reviewer to specify whether each individual comment is a required change request or an optional non-blocking request/comment.Beta Was this translation helpful? Give feedback.
All reactions