update for other pr decision

Author: nielsdos

ext/dom/parentnode/tree.c

@@ -35,13 +35,11 @@ zend_result dom_parent_node_children_read(dom_object *obj, zval *retval)
 {
 	zval *cached_children = dom_parent_node_children(obj);
 	if (Z_ISUNDEF_P(cached_children)) {
-		bool rc1 = GC_REFCOUNT(&obj->std) == 1;
 		object_init_ex(cached_children, dom_html_collection_class_entry);
 		php_dom_create_obj_map(obj, Z_DOMOBJ_P(cached_children), NULL, NULL, NULL, &php_dom_obj_map_child_elements);
 
-		/* Handle cycles for TMPVARs */
-		/* TODO: depending on the solution for GH-18907, this may need changes */
-		if (rc1) {
+		/* Handle cycles for TMPVARs, RC == 2 because of 1 TMPVAR and 1 in HTMLCollection */
+		if (GC_REFCOUNT(&obj->std) == 2) {
 			gc_possible_root(Z_COUNTED_P(cached_children));
 		}
 	}