Skip to content

feat(typography): add JUSTIFIED horizontal alignment for bounded text in 2D renderer #8294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(typography): add JUSTIFIED horizontal alignment for bounded text in 2D renderer #8294

wants to merge 4 commits into from
+212 −2

Conversation

@Vansh0204
Copy link

@Vansh0204 Vansh0204 commented Nov 25, 2025 •
edited
Loading

PR 1

  • Adds textAlign(JUSTIFIED) support in the 2D renderer for bounded text(...) .
  • Distributes inter-word spacing to fill maxWidth on non-final lines; final line remains ragged.
  • Canvas2D maps JUSTIFIED to LEFT internally; WEBGL remains left-aligned for now.
  • Lint/build pass locally. Follow-up PR will add textWrap(PRETTY) and BALANCE .

Addresses #7712
@Vansh0204
feat(typography): add JUSTIFIED alignment for bounded text in 2D rend…
05aa09a 
…erer

- Justifies non-final lines in bounded text()
- Keeps final line ragged
- Maps Canvas2D textAlign to LEFT when JUSTIFIED is set
- WEBGL remains left-aligned for now

Refs processing#7712
@Vansh0204 Vansh0204 force-pushed the feat/justified-align-pr1 branch from 96200c1 to 05aa09a Compare November 27, 2025 18:23
@dhowe
Copy link
Contributor

dhowe commented Nov 27, 2025

@Vansh0204 have you created tests for this feature?
@Vansh0204
Copy link
Author

Vansh0204 commented Nov 28, 2025

Thanks for reviewing, sir! I haven't added tests yet – I'll add comprehensive unit tests for JUSTIFIED alignment in the 2D renderer covering inter-word spacing distribution and edge cases. I'll push them shortly.
@dhowe
Copy link
Contributor

dhowe commented Nov 28, 2025

a good place to start would be the alignment tests in https://github.com/processing/p5.js/blob/dev-2.0/test/manual-test-examples/type/index.html

image

eventually we will also need pixel-based tests like those here: https://github.com/processing/p5.js/blob/dev-2.0/test/unit/visual/cases/typography.js
@Vansh0204
Copy link
Author

Vansh0204 commented Nov 30, 2025

Hi @dhowe, sir! I've updated the PRs to include the necessary tests.
Screenshot 2025-12-01 at 12 05 08 AM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@Vansh0204 @dhowe