Skip to content

Make the ascii progress bar really be ascii, not Unicode #5671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 6, 2019
Merged

Make the ascii progress bar really be ascii, not Unicode #5671

merged 2 commits into from
Jul 6, 2019

Conversation

@segevfiner
Copy link
Contributor

@segevfiner segevfiner commented Jul 29, 2018 •
edited
Loading

Found while debugging #5665 (Not a fix for that issue)
@pfmoore pfmoore mentioned this pull request Jul 30, 2018
Closed
@uranusjr uranusjr mentioned this pull request Oct 17, 2018
Closed
@uranusjr uranusjr mentioned this pull request Nov 9, 2018
Closed
@pradyunsg pradyunsg added OS: windows Windows specific C: encoding Related to text encoding and likely, UnicodeErrors labels Nov 9, 2018
pradyunsg
pradyunsg approved these changes Nov 9, 2018
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love how the NEWS fragment reads. ^.^
@pradyunsg pradyunsg requested a review from pfmoore November 9, 2018 07:53
@pradyunsg
Copy link
Member

pradyunsg commented Nov 9, 2018

For easier reference, the links to GitHub source code of the changed base classes:

Bar: https://github.com/verigak/progress/blob/1.4/progress/bar.py#L25
IncrementalBar: https://github.com/verigak/progress/blob/1.4/progress/bar.py#L66
@pradyunsg pradyunsg merged commit d4f0f4e into pypa:master Jul 6, 2019
@pradyunsg
Copy link
Member

pradyunsg commented Jul 6, 2019

Thanks for this @segevfiner! :)
@segevfiner segevfiner deleted the ascii-progress-bar-fix branch July 6, 2019 08:58
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Aug 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

auto-locked Outdated issues that have been locked by automation C: encoding Related to text encoding and likely, UnicodeErrors OS: windows Windows specific

2 participants

@segevfiner @pradyunsg