Remove --always-unzip

The --always-unzip option is specified as Deprecated in the code comments, and is not visible to the end-user (also see #2429 (comment)):

pip/src/pip/_internal/cli/cmdoptions.py

Lines 827 to 838 in 19e739c

    
           # Deprecated, Remove later 
        
           always_unzip = partial( 
        
               Option, 
        
               '-Z', '--always-unzip', 
        
               dest='always_unzip', 
        
               action='store_true', 
        
               help=SUPPRESS_HELP, 
        
           )  # type: Callable[..., Option] 
        
           # TODO: Move into a class that inherits from partial, currently does not 
        
           # work as mypy complains functools.partial is a generic class. 
        
           # This way we know we can ignore this option in docs auto generation 
        
           setattr(always_unzip, 'deprecated', True)

And is also a no-op (we have a test which checks that as well when used in requirements.txt)

pip/tests/unit/test_req_file.py

Lines 381 to 383 in 19e739c

    
           def test_noop_always_unzip(self, line_processor, finder): 
        
               # noop, but confirm it can be set 
        
               line_processor("--always-unzip", "file", 1, finder=finder)

Given those facts, we can go ahead and remove --always-unzip from the source code and tests.

If this is something we agree upon, I can go ahead and create a PR for the same.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove --always-unzip #8408

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	# Deprecated, Remove later
	always_unzip = partial(
	Option,
	'-Z', '--always-unzip',
	dest='always_unzip',
	action='store_true',
	help=SUPPRESS_HELP,
	) # type: Callable[..., Option]
	# TODO: Move into a class that inherits from partial, currently does not
	# work as mypy complains functools.partial is a generic class.
	# This way we know we can ignore this option in docs auto generation
	setattr(always_unzip, 'deprecated', True)

	def test_noop_always_unzip(self, line_processor, finder):
	# noop, but confirm it can be set
	line_processor("--always-unzip", "file", 1, finder=finder)

Remove --always-unzip #8408

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions